Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: extensions/common/features/complex_feature_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/complex_feature_unittest.cc
diff --git a/extensions/common/features/complex_feature_unittest.cc b/extensions/common/features/complex_feature_unittest.cc
index 0dd7c8f5eecd7987dbe17eaa6269d5f026674b56..f60c90026a943c4f9fa016a6cad9e8951f6a6e42 100644
--- a/extensions/common/features/complex_feature_unittest.cc
+++ b/extensions/common/features/complex_feature_unittest.cc
@@ -24,8 +24,8 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
scoped_ptr<SimpleFeature> simple_feature(new SimpleFeature);
scoped_ptr<base::DictionaryValue> rule(
DictionaryBuilder()
- .Set("whitelist", std::move(ListBuilder().Append(kIdFoo)))
- .Set("extension_types", std::move(ListBuilder().Append("extension")))
+ .Set("whitelist", ListBuilder().Append(kIdFoo).Build())
+ .Set("extension_types", ListBuilder().Append("extension").Build())
.Build());
simple_feature->Parse(rule.get());
features->push_back(std::move(simple_feature));
@@ -33,9 +33,9 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
// Rule: "legacy_packaged_app", whitelist "bar".
simple_feature.reset(new SimpleFeature);
rule = DictionaryBuilder()
- .Set("whitelist", std::move(ListBuilder().Append(kIdBar)))
+ .Set("whitelist", ListBuilder().Append(kIdBar).Build())
.Set("extension_types",
- std::move(ListBuilder().Append("legacy_packaged_app")))
+ ListBuilder().Append("legacy_packaged_app").Build())
.Build();
simple_feature->Parse(rule.get());
features->push_back(std::move(simple_feature));
@@ -86,8 +86,8 @@ TEST(ComplexFeatureTest, Dependencies) {
scoped_ptr<SimpleFeature> simple_feature(new SimpleFeature);
scoped_ptr<base::DictionaryValue> rule =
DictionaryBuilder()
- .Set("dependencies", std::move(ListBuilder().Append(
- "manifest:content_security_policy")))
+ .Set("dependencies",
+ ListBuilder().Append("manifest:content_security_policy").Build())
.Build();
simple_feature->Parse(rule.get());
features->push_back(std::move(simple_feature));
@@ -96,7 +96,7 @@ TEST(ComplexFeatureTest, Dependencies) {
simple_feature.reset(new SimpleFeature);
rule = DictionaryBuilder()
.Set("dependencies",
- std::move(ListBuilder().Append("permission:serial")))
+ ListBuilder().Append("permission:serial").Build())
.Build();
simple_feature->Parse(rule.get());
features->push_back(std::move(simple_feature));

Powered by Google App Engine
This is Rietveld 408576698