Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: extensions/browser/value_store/value_store_change_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/value_store_change_unittest.cc
diff --git a/extensions/browser/value_store/value_store_change_unittest.cc b/extensions/browser/value_store/value_store_change_unittest.cc
index 123385b8418ce7cd0f6d69aad98736fa54bae5c9..895f1ac71ee039fd62b7c542f6f23c1511738032 100644
--- a/extensions/browser/value_store/value_store_change_unittest.cc
+++ b/extensions/browser/value_store/value_store_change_unittest.cc
@@ -61,7 +61,7 @@ TEST(ValueStoreChangeTest, ToJson) {
DictionaryBuilder()
.Set("key", "value")
.Set("key.with.dots", "value.with.dots")
- .Set("tricked", std::move(DictionaryBuilder().Set("you", "nodots")))
+ .Set("tricked", DictionaryBuilder().Set("you", "nodots").Build())
.Set("tricked.you", "with.dots")
.Build();
@@ -81,12 +81,14 @@ TEST(ValueStoreChangeTest, ToJson) {
DictionaryBuilder v4(*value);
scoped_ptr<base::DictionaryValue> expected_from_json =
DictionaryBuilder()
- .Set("key", std::move(DictionaryBuilder()
- .Set("oldValue", std::move(v1))
- .Set("newValue", std::move(v2))))
- .Set("key.with.dots", std::move(DictionaryBuilder()
- .Set("oldValue", std::move(v3))
- .Set("newValue", std::move(v4))))
+ .Set("key", DictionaryBuilder()
+ .Set("oldValue", v1.Build())
+ .Set("newValue", v2.Build())
+ .Build())
+ .Set("key.with.dots", DictionaryBuilder()
+ .Set("oldValue", v3.Build())
+ .Set("newValue", v4.Build())
+ .Build())
.Build();
EXPECT_TRUE(from_json->Equals(expected_from_json.get()));

Powered by Google App Engine
This is Rietveld 408576698