Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9814)

Unified Diff: chrome/common/pepper_permission_util_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/pepper_permission_util_unittest.cc
diff --git a/chrome/common/pepper_permission_util_unittest.cc b/chrome/common/pepper_permission_util_unittest.cc
index 2684d5f3e2fe750109c28042259c5be8bf3a0aaf..c2155d61f150793362ad2b21ff2b81d8224b6b8f 100644
--- a/chrome/common/pepper_permission_util_unittest.cc
+++ b/chrome/common/pepper_permission_util_unittest.cc
@@ -31,8 +31,10 @@ scoped_refptr<Extension> CreateExtensionImportingModule(
.Set("name", "Has Dependent Modules")
.Set("version", "1.0")
.Set("manifest_version", 2)
- .Set("import", std::move(ListBuilder().Append(std::move(
- DictionaryBuilder().Set("id", import_id)))))
+ .Set("import",
+ ListBuilder()
+ .Append(DictionaryBuilder().Set("id", import_id).Build())
+ .Build())
.Build();
return ExtensionBuilder()
@@ -92,13 +94,13 @@ TEST(PepperPermissionUtilTest, SharedModuleWhitelisting) {
.Set("version", "1.0")
.Set("manifest_version", 2)
.Set("export",
- std::move(
- DictionaryBuilder()
- .Set("resources", std::move(ListBuilder().Append("*")))
- // Add the extension to the whitelist. This
- // restricts import to |whitelisted_id| only.
- .Set("whitelist",
- std::move(ListBuilder().Append(whitelisted_id)))))
+ DictionaryBuilder()
+ .Set("resources", ListBuilder().Append("*").Build())
+ // Add the extension to the whitelist. This
+ // restricts import to |whitelisted_id| only.
+ .Set("whitelist",
+ ListBuilder().Append(whitelisted_id).Build())
+ .Build())
.Build();
scoped_refptr<Extension> shared_module =
ExtensionBuilder().SetManifest(std::move(shared_module_manifest)).Build();

Powered by Google App Engine
This is Rietveld 408576698