chrome/browser/notifications/platform_notification_service_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/notifications/message_center_settings_controller_unittest.cc ('k') | chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_unittest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc

index ed51422fe363507c45796c9a5a6ab5c3c806e6da..282ed6754ba702155c0b1417335fe80722be14c0 100644

--- a/chrome/browser/notifications/platform_notification_service_unittest.cc

+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc

@@ -294,11 +294,12 @@ TEST_F(PlatformNotificationServiceTest, DisplayNameForContextMessage) {

scoped_refptr<extensions::Extension> extension =

extensions::ExtensionBuilder()

.SetID("honijodknafkokifofgiaalefdiedpko")

- .SetManifest(std::move(extensions::DictionaryBuilder()

- .Set("name", "NotificationTest")

- .Set("version", "1.0")

- .Set("manifest_version", 2)

- .Set("description", "Test Extension")))

+ .SetManifest(extensions::DictionaryBuilder()

+ .Set("name", "NotificationTest")

+ .Set("version", "1.0")

+ .Set("manifest_version", 2)

+ .Set("description", "Test Extension")

+ .Build())

.Build();

extensions::ExtensionRegistry* registry =

@@ -333,14 +334,15 @@ TEST_F(PlatformNotificationServiceTest, ExtensionPermissionChecks) {

scoped_refptr<extensions::Extension> extension =

extensions::ExtensionBuilder()

.SetManifest(

- std::move(extensions::DictionaryBuilder()

- .Set("name", "NotificationTest")

- .Set("version", "1.0")

- .Set("manifest_version", 2)

- .Set("description", "Test Extension")

- .Set("permissions",

- std::move(extensions::ListBuilder().Append(

- "notifications")))))

+ extensions::DictionaryBuilder()

+ .Set("name", "NotificationTest")

+ .Set("version", "1.0")

+ .Set("manifest_version", 2)

+ .Set("description", "Test Extension")

+ .Set(

+ "permissions",

+ extensions::ListBuilder().Append("notifications").Build())

+ .Build())

.Build();

// Install the extension on the faked extension service, and verify that it

@@ -382,11 +384,12 @@ TEST_F(PlatformNotificationServiceTest, CreateNotificationFromData) {

scoped_refptr<extensions::Extension> extension =

extensions::ExtensionBuilder()

.SetID("honijodknafkokifofgiaalefdiedpko")

- .SetManifest(std::move(extensions::DictionaryBuilder()

- .Set("name", "NotificationTest")

- .Set("version", "1.0")

- .Set("manifest_version", 2)

- .Set("description", "Test Extension")))

+ .SetManifest(extensions::DictionaryBuilder()

+ .Set("name", "NotificationTest")

+ .Set("version", "1.0")

+ .Set("manifest_version", 2)

+ .Set("description", "Test Extension")

+ .Build())

.Build();

extensions::ExtensionRegistry* registry =