chrome/browser/extensions/test_extension_environment.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/test_extension_environment.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/shared_module_service_unittest.cc ('k') | chrome/browser/extensions/webstore_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/test_extension_environment.cc

diff --git a/chrome/browser/extensions/test_extension_environment.cc b/chrome/browser/extensions/test_extension_environment.cc

index a85b5d47cc9701f6d0a4eb00ccd50cb3f0fc8ced..37f5628b40e3cf803ac84c0f74dd1ed7ab517814 100644

--- a/chrome/browser/extensions/test_extension_environment.cc

+++ b/chrome/browser/extensions/test_extension_environment.cc

@@ -60,11 +60,14 @@ scoped_ptr<base::DictionaryValue> MakePackagedAppManifest() {

.Set("name", "Test App Name")

.Set("version", "2.0")

.Set("manifest_version", 2)

- .Set("app", std::move(extensions::DictionaryBuilder().Set(

- "background",

- std::move(extensions::DictionaryBuilder().Set(

- "scripts", std::move(extensions::ListBuilder().Append(

- "background.js")))))))

+ .Set("app", extensions::DictionaryBuilder()

+ .Set("background",

+ extensions::DictionaryBuilder()

+ .Set("scripts", extensions::ListBuilder()

+ .Append("background.js")

+ .Build())

.Build();

}