Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: chrome/browser/extensions/options_page_apitest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/options_page_apitest.cc
diff --git a/chrome/browser/extensions/options_page_apitest.cc b/chrome/browser/extensions/options_page_apitest.cc
index 62f47085bd556cf7e619132998e2cde49a1f370b..4026aaee627ce63ab190fb0bf1138a2af3680e74 100644
--- a/chrome/browser/extensions/options_page_apitest.cc
+++ b/chrome/browser/extensions/options_page_apitest.cc
@@ -78,7 +78,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest,
.Set("manifest_version", 2)
.Set("name", "Extension for options param test")
.Set("options_ui",
- std::move(DictionaryBuilder().Set("page", "options.html")))
+ DictionaryBuilder().Set("page", "options.html").Build())
.Set("version", "1")
.ToJSON());

Powered by Google App Engine
This is Rietveld 408576698