chrome/browser/extensions/extension_web_ui_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_web_ui_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/extension_service_sync_unittest.cc ('k') | chrome/browser/extensions/location_bar_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_web_ui_unittest.cc

diff --git a/chrome/browser/extensions/extension_web_ui_unittest.cc b/chrome/browser/extensions/extension_web_ui_unittest.cc

index 12cb23a2d2d9caa0795374c18b8763ca26ad01bf..f75a5316ec8af923eb301745e82da2d12cfb41ef 100644

--- a/chrome/browser/extensions/extension_web_ui_unittest.cc

+++ b/chrome/browser/extensions/extension_web_ui_unittest.cc

@@ -77,10 +77,10 @@ TEST_F(ExtensionWebUITest, ExtensionURLOverride) {

manifest.Set(manifest_keys::kName, "ext1")

.Set(manifest_keys::kVersion, "0.1")

.Set(std::string(manifest_keys::kChromeURLOverrides),

- std::move(DictionaryBuilder().Set("bookmarks", kOverrideResource)));

+ DictionaryBuilder().Set("bookmarks", kOverrideResource).Build());

scoped_refptr<Extension> ext_unpacked(

ExtensionBuilder()

- .SetManifest(std::move(manifest))

+ .SetManifest(manifest.Build())

.SetLocation(Manifest::UNPACKED)

.SetID("abcdefghijabcdefghijabcdefghijaa")

.Build());

@@ -112,10 +112,10 @@ TEST_F(ExtensionWebUITest, ExtensionURLOverride) {

manifest2.Set(manifest_keys::kName, "ext2")

.Set(manifest_keys::kVersion, "0.1")

.Set(std::string(manifest_keys::kChromeURLOverrides),

- std::move(DictionaryBuilder().Set("bookmarks", kOverrideResource2)));

+ DictionaryBuilder().Set("bookmarks", kOverrideResource2).Build());

scoped_refptr<Extension> ext_component(

ExtensionBuilder()

- .SetManifest(std::move(manifest2))

+ .SetManifest(manifest2.Build())

.SetLocation(Manifest::COMPONENT)

.SetID("bbabcdefghijabcdefghijabcdefghij")

.Build());