chrome/browser/extensions/extension_prefs_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/extension_migrator_unittest.cc ('k') | chrome/browser/extensions/extension_reenabler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_prefs_unittest.cc

diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc

index 1f2239d7e46392a0aa879d47a541c44b3179d3cb..e24698dfb8828a2b66d91a9f17343087a1d3db55 100644

--- a/chrome/browser/extensions/extension_prefs_unittest.cc

+++ b/chrome/browser/extensions/extension_prefs_unittest.cc

@@ -922,9 +922,10 @@ class ExtensionPrefsComponentExtension : public ExtensionPrefsTest {

// Adding a component extension.

component_extension_ =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set(manifest_keys::kName, "a")

- .Set(manifest_keys::kVersion, "0.1")))

+ .SetManifest(DictionaryBuilder()

+ .Set(manifest_keys::kName, "a")

+ .Set(manifest_keys::kVersion, "0.1")

+ .Build())

.SetLocation(Manifest::COMPONENT)

.SetPath(prefs_.extensions_dir().AppendASCII("a"))

.Build();

@@ -933,9 +934,10 @@ class ExtensionPrefsComponentExtension : public ExtensionPrefsTest {

// Adding a non component extension.

no_component_extension_ =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set(manifest_keys::kName, "b")

- .Set(manifest_keys::kVersion, "0.1")))

+ .SetManifest(DictionaryBuilder()

+ .Set(manifest_keys::kName, "b")

+ .Set(manifest_keys::kVersion, "0.1")

+ .Build())

.SetLocation(Manifest::INTERNAL)

.SetPath(prefs_.extensions_dir().AppendASCII("b"))

.Build();