Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2476)

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_messages_apitest.cc
diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc
index 682a3faedac65cde3d64ebbb56e4c90e526b0ba6..ab7b6d0fd085049842873c692a28aeecd8218e53 100644
--- a/chrome/browser/extensions/extension_messages_apitest.cc
+++ b/chrome/browser/extensions/extension_messages_apitest.cc
@@ -522,10 +522,11 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest, NotInstalled) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
.SetID("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Fake extension")
- .Set("version", "1")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Fake extension")
+ .Set("version", "1")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
ui_test_utils::NavigateToURL(browser(), chromium_org_url());
@@ -1238,10 +1239,11 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,
ExtensionBuilder()
// A bit scary that this works...
.SetID("invalid")
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Fake extension")
- .Set("version", "1")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Fake extension")
+ .Set("version", "1")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
ui_test_utils::NavigateToURL(browser(), chromium_org_url());

Powered by Google App Engine
This is Rietveld 408576698