chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/api/file_system/file_system_api_unittest.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index da7aaf1797e47ab49eaa14d674d1ce04166d34cd..33a298064a57a046db6d9635cb62054bec29c285 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -1658,16 +1658,16 @@ class GetAuthTokenFunctionPublicSessionTest : public GetAuthTokenFunctionTest {

scoped_refptr<Extension> CreateTestExtension(const std::string& id) {

return ExtensionBuilder()

- .SetManifest(std::move(

+ .SetManifest(

DictionaryBuilder()

.Set("name", "Test")

.Set("version", "1.0")

.Set("oauth2",

- std::move(

- DictionaryBuilder()

- .Set("client_id", "clientId")

- .Set("scopes",

- std::move(ListBuilder().Append("scope1")))))))

+ DictionaryBuilder()

+ .Set("client_id", "clientId")

+ .Set("scopes", ListBuilder().Append("scope1").Build())

+ .Build())

.SetLocation(Manifest::UNPACKED)

.SetID(id)

.Build();