Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4550)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
index fc9f330c7dc32a89b006f6236d1090537d58551d..ff79cf21fb59a0cdcb6aafcf9e10d854855effe8 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
@@ -152,7 +152,7 @@ const Extension* DeveloperPrivateApiUnitTest::LoadSimpleExtension() {
.Set("description", "an extension");
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(manifest))
+ .SetManifest(manifest.Build())
.SetLocation(Manifest::INTERNAL)
.SetID(id)
.Build();
@@ -516,9 +516,10 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateDeleteExtensionErrors) {
api::developer_private::ERROR_TYPE_MANIFEST);
scoped_ptr<base::ListValue> args =
ListBuilder()
- .Append(std::move(DictionaryBuilder()
- .Set("extensionId", extension->id())
- .Set("type", type_string)))
+ .Append(DictionaryBuilder()
+ .Set("extensionId", extension->id())
+ .Set("type", type_string)
+ .Build())
.Build();
scoped_refptr<UIThreadExtensionFunction> function =
new api::DeveloperPrivateDeleteExtensionErrorsFunction();
@@ -532,10 +533,10 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateDeleteExtensionErrors) {
int error_id = error_list[0]->id();
args =
ListBuilder()
- .Append(std::move(
- DictionaryBuilder()
- .Set("extensionId", extension->id())
- .Set("errorIds", std::move(ListBuilder().Append(error_id)))))
+ .Append(DictionaryBuilder()
+ .Set("extensionId", extension->id())
+ .Set("errorIds", ListBuilder().Append(error_id).Build())
+ .Build())
.Build();
function = new api::DeveloperPrivateDeleteExtensionErrorsFunction();
EXPECT_TRUE(RunFunction(function, *args)) << function->GetError();
@@ -543,10 +544,11 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateDeleteExtensionErrors) {
EXPECT_EQ(1u, error_console->GetErrorsForExtension(extension->id()).size());
// Finally remove all errors for the extension.
- args = ListBuilder()
- .Append(std::move(
- DictionaryBuilder().Set("extensionId", extension->id())))
- .Build();
+ args =
+ ListBuilder()
+ .Append(
+ DictionaryBuilder().Set("extensionId", extension->id()).Build())
+ .Build();
function = new api::DeveloperPrivateDeleteExtensionErrorsFunction();
EXPECT_TRUE(RunFunction(function, *args)) << function->GetError();
// No more errors!

Powered by Google App Engine
This is Rietveld 408576698