chrome/browser/extensions/active_script_controller_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_script_controller_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc ('k') | chrome/browser/extensions/active_tab_unittest.cc » ('j') | chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_script_controller_unittest.cc

diff --git a/chrome/browser/extensions/active_script_controller_unittest.cc b/chrome/browser/extensions/active_script_controller_unittest.cc

index a05f521fc8d255a8c896960b1eef0c5938ca15da..b436ce4483eecd4fcefed24849153884ddd245f3 100644

--- a/chrome/browser/extensions/active_script_controller_unittest.cc

+++ b/chrome/browser/extensions/active_script_controller_unittest.cc

@@ -107,14 +107,15 @@ const Extension* ActiveScriptControllerUnitTest::AddExtension() {

const std::string kId = crx_file::id_util::GenerateId("all_hosts_extension");

extension_ =

ExtensionBuilder()

- .SetManifest(std::move(

+ .SetManifest(

DictionaryBuilder()

.Set("name", "all_hosts_extension")

.Set("description", "an extension")

.Set("manifest_version", 2)

.Set("version", "1.0.0")

.Set("permissions",

- std::move(ListBuilder().Append(kAllHostsPermission)))))

+ ListBuilder().Append(kAllHostsPermission).Build())

+ .Build())

.SetLocation(Manifest::INTERNAL)

.SetID(kId)

.Build();