chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/file_manager/file_tasks_unittest.cc » ('j') | chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc

diff --git a/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc b/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc

index 204b43d7d69fb06bc37a98e8d6b1724d50a20a05..e743619ab0e898f40ec238dd44349336167b364f 100644

--- a/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc

+++ b/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc

@@ -105,9 +105,10 @@ TEST_F(ShortcutsProviderExtensionTest, Extension) {

// Claim the extension has been unloaded.

scoped_refptr<const extensions::Extension> extension =

extensions::ExtensionBuilder()

- .SetManifest(std::move(extensions::DictionaryBuilder()

- .Set("name", "Echo")

- .Set("version", "1.0")))

+ .SetManifest(extensions::DictionaryBuilder()

+ .Set("name", "Echo")

+ .Set("version", "1.0")

+ .Build())

.SetID("cedabbhfglmiikkmdgcpjdkocfcmbkee")

.Build();

extensions::UnloadedExtensionInfo details(