Java side of purging BookmarkId from offline pages

chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
index 84d5d996f387c95bb2151bea1bca9a19f4325531..82a4c71f01cc89b38c48655c5bf03f1133ed83c9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
@@ -90,7 +90,8 @@ public class BookmarkBookmarkRow extends BookmarkRow implements LargeIconCallbac
         OfflinePageItem offlinePage = null;
         OfflinePageBridge bridge = mDelegate.getModel().getOfflinePageBridge();
         if (mDelegate.getCurrentState() == BookmarkUIState.STATE_FILTER && bridge != null) {
-            offlinePage = bridge.getPageByBookmarkId(bookmarkId);
+            offlinePage = bridge.getPageByClientId(
+                    BookmarkModel.offlineClientIdForBookmarkId(bookmarkId));

[fgorski, 2016/02/29 18:42:28]

Have you considered adding a small adapter for bookmarks, e.g.
BookmarkOfflinePageClient, that would hide the double calls and expose the
current Bookmark ID based interface?

I am not saying that is the best solution, but something worth looking at.

[bburns, 2016/02/29 21:41:22]

Hrm, I'm not sure I'm super happy about wrappers on top of wrappers.  I don't
think that this code is that bad, and its definitely more explicit about what is
going on underneath.

         }
         TextView textView = (TextView) findViewById(R.id.offline_page_size);
         View bookmarkRowView = findViewById(R.id.bookmark_row);