Java side of purging BookmarkId from offline pages

chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.bookmarks;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.drawable.BitmapDrawable;
 import android.support.v4.graphics.drawable.RoundedBitmapDrawable;
@@ skipping 72 matching lines @@
         mTitleView.setText(item.getTitle());
         mDelegate.getLargeIconBridge().getLargeIconForUrl(mUrl, mMinIconSize, this);
         updateOfflinePageSize(bookmarkId);
         return item;
     }
 
     private void updateOfflinePageSize(BookmarkId bookmarkId) {
         OfflinePageItem offlinePage = null;
         OfflinePageBridge bridge = mDelegate.getModel().getOfflinePageBridge();
         if (mDelegate.getCurrentState() == BookmarkUIState.STATE_FILTER && bridge != null) {
-            offlinePage = bridge.getPageByBookmarkId(bookmarkId);
+            offlinePage = bridge.getPageByClientId(
+                    BookmarkModel.offlineClientIdForBookmarkId(bookmarkId));

[fgorski, 2016/02/29 18:42:28]

Have you considered adding a small adapter for bookmarks, e.g.
BookmarkOfflinePageClient, that would hide the double calls and expose the
current Bookmark ID based interface?

I am not saying that is the best solution, but something worth looking at.

[bburns, 2016/02/29 21:41:22]

Hrm, I'm not sure I'm super happy about wrappers on top of wrappers.  I don't
think that this code is that bad, and its definitely more explicit about what is
going on underneath.

         }
         TextView textView = (TextView) findViewById(R.id.offline_page_size);
         View bookmarkRowView = findViewById(R.id.bookmark_row);
         if (offlinePage != null) {
             int verticalPadding = textView.getResources().getDimensionPixelSize(
                     R.dimen.offline_page_item_vertical_spacing);
             textView.setText(Formatter.formatFileSize(getContext(), offlinePage.getFileSize()));
             // Get the embedded bookmark_row layout, and add padding.  This is because the entries
             // in filter view are larger (contain more items) than normal bookmark view.
             bookmarkRowView.setPadding(0, verticalPadding / 2, 0, verticalPadding / 2);
@@ skipping 15 matching lines @@
             mIconImageView.setImageDrawable(new BitmapDrawable(getResources(), icon));
         } else {
             RoundedBitmapDrawable roundedIcon = RoundedBitmapDrawableFactory.create(
                     getResources(),
                     Bitmap.createScaledBitmap(icon, mDisplayedIconSize, mDisplayedIconSize, false));
             roundedIcon.setCornerRadius(mCornerRadius);
             mIconImageView.setImageDrawable(roundedIcon);
         }
     }
 }