Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: webkit/common/user_agent/user_agent_util.h

Issue 17389005: [Android] Abandon bundling DevTools frontends for mobile apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simpler approach, no component Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/user_agent/user_agent_util.h
diff --git a/webkit/common/user_agent/user_agent_util.h b/webkit/common/user_agent/user_agent_util.h
index 3fbdf5488792d91f8bc8c7b331c598b3db7b8443..e23b809a5050fe1e5fae2a6b1be1f4c440f61f1e 100644
--- a/webkit/common/user_agent/user_agent_util.h
+++ b/webkit/common/user_agent/user_agent_util.h
@@ -22,6 +22,8 @@ WEBKIT_USER_AGENT_EXPORT std::string GetWebKitVersion();
WEBKIT_USER_AGENT_EXPORT int GetWebKitMajorVersion();
WEBKIT_USER_AGENT_EXPORT int GetWebKitMinorVersion();
+WEBKIT_USER_AGENT_EXPORT std::string GetWebKitRevision();
jamesr 2013/06/20 18:49:47 what does this number mean on release branches?
mnaganov (inactive) 2013/06/20 20:11:09 It's always the number of the svn revision. Every
bulach 2013/06/21 09:02:17 isn't it safer to just rely on GetWebKitVersion()
mnaganov (inactive) 2013/06/21 09:21:45 GetWebKitVersion doesn't provide any more useful i
+
// Helper function to generate a full user agent string from a short
// product name.
WEBKIT_USER_AGENT_EXPORT std::string BuildUserAgentFromProduct(
« chrome/browser/android/dev_tools_server.cc ('K') | « content/shell/shell_devtools_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698