Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: webkit/common/user_agent/user_agent_util.h

Issue 17389005: [Android] Abandon bundling DevTools frontends for mobile apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simpler approach, no component Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_COMMON_USER_AGENT_USER_AGENT_UTIL_H_ 5 #ifndef WEBKIT_COMMON_USER_AGENT_USER_AGENT_UTIL_H_
6 #define WEBKIT_COMMON_USER_AGENT_USER_AGENT_UTIL_H_ 6 #define WEBKIT_COMMON_USER_AGENT_USER_AGENT_UTIL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "webkit/common/user_agent/webkit_user_agent_export.h" 11 #include "webkit/common/user_agent/webkit_user_agent_export.h"
12 12
13 namespace webkit_glue { 13 namespace webkit_glue {
14 14
15 // Builds a User-agent compatible string that describes the OS and CPU type. 15 // Builds a User-agent compatible string that describes the OS and CPU type.
16 WEBKIT_USER_AGENT_EXPORT std::string BuildOSCpuInfo(); 16 WEBKIT_USER_AGENT_EXPORT std::string BuildOSCpuInfo();
17 17
18 // Returns the WebKit version, in the form "major.minor (branch@revision)". 18 // Returns the WebKit version, in the form "major.minor (branch@revision)".
19 WEBKIT_USER_AGENT_EXPORT std::string GetWebKitVersion(); 19 WEBKIT_USER_AGENT_EXPORT std::string GetWebKitVersion();
20 20
21 // The following 2 functions return the major and minor webkit versions. 21 // The following 2 functions return the major and minor webkit versions.
22 WEBKIT_USER_AGENT_EXPORT int GetWebKitMajorVersion(); 22 WEBKIT_USER_AGENT_EXPORT int GetWebKitMajorVersion();
23 WEBKIT_USER_AGENT_EXPORT int GetWebKitMinorVersion(); 23 WEBKIT_USER_AGENT_EXPORT int GetWebKitMinorVersion();
24 24
25 WEBKIT_USER_AGENT_EXPORT std::string GetWebKitRevision();
jamesr 2013/06/20 18:49:47 what does this number mean on release branches?
mnaganov (inactive) 2013/06/20 20:11:09 It's always the number of the svn revision. Every
bulach 2013/06/21 09:02:17 isn't it safer to just rely on GetWebKitVersion()
mnaganov (inactive) 2013/06/21 09:21:45 GetWebKitVersion doesn't provide any more useful i
26
25 // Helper function to generate a full user agent string from a short 27 // Helper function to generate a full user agent string from a short
26 // product name. 28 // product name.
27 WEBKIT_USER_AGENT_EXPORT std::string BuildUserAgentFromProduct( 29 WEBKIT_USER_AGENT_EXPORT std::string BuildUserAgentFromProduct(
28 const std::string& product); 30 const std::string& product);
29 31
30 // Builds a full user agent string given a string describing the OS and a 32 // Builds a full user agent string given a string describing the OS and a
31 // product name. 33 // product name.
32 WEBKIT_USER_AGENT_EXPORT std::string BuildUserAgentFromOSAndProduct( 34 WEBKIT_USER_AGENT_EXPORT std::string BuildUserAgentFromOSAndProduct(
33 const std::string& os_info, 35 const std::string& os_info,
34 const std::string& product); 36 const std::string& product);
35 37
36 } // namespace webkit_glue 38 } // namespace webkit_glue
37 39
38 #endif // WEBKIT_COMMON_USER_AGENT_USER_AGENT_UTIL_H_ 40 #endif // WEBKIT_COMMON_USER_AGENT_USER_AGENT_UTIL_H_
OLDNEW
« chrome/browser/android/dev_tools_server.cc ('K') | « content/shell/shell_devtools_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698