Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: mojo/shell/application_manager.h

Issue 1738663002: Hook embedded shell up to MojoShellConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/application_manager.h
diff --git a/mojo/shell/application_manager.h b/mojo/shell/application_manager.h
index b6e657c426b8c8a1b4aa53579dc41f6cc2d1fa8d..b5c664c6bc71c4cb910139d494d574b69f491e6f 100644
--- a/mojo/shell/application_manager.h
+++ b/mojo/shell/application_manager.h
@@ -80,6 +80,13 @@ class ApplicationManager : public ShellClient,
// instance of the target application is running, one will be loaded.
void Connect(scoped_ptr<ConnectParams> params);
+ // Creates a new ApplicationInstance for the target application identified by
+ // |params|. No resolution is done on the target URL and there must not be any
+ // existing instances for the given URL. Returns a pending ShellClientRequest
+ // for the instance.
Ben Goodger (Google) 2016/02/25 03:02:58 I'm wondering if we can make this method sound les
Ken Rockot(use gerrit already) 2016/02/25 04:42:05 sgtm and done
+ mojom::ShellClientRequest CreateInstanceForURL(
+ scoped_ptr<ConnectParams> params);
+
// Sets the default Loader to be used if not overridden by SetLoaderForURL().
void set_default_loader(scoped_ptr<ApplicationLoader> loader) {
default_loader_ = std::move(loader);

Powered by Google App Engine
This is Rietveld 408576698