Hook embedded shell up to MojoShellConnection

mojo/shell/application_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SHELL_APPLICATION_MANAGER_H_
 #define MOJO_SHELL_APPLICATION_MANAGER_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 62 matching lines @@
   // Provide a callback to be notified whenever an instance is destroyed.
   // Typically the creator of the ApplicationManager will use this to determine
   // when some set of instances it created are destroyed, so it can shut down.
   void SetInstanceQuitCallback(base::Callback<void(const Identity&)> callback);
 
   // Completes a connection between a source and target application as defined
   // by |params|, exchanging InterfaceProviders between them. If no existing
   // instance of the target application is running, one will be loaded.
   void Connect(scoped_ptr<ConnectParams> params);
 
+  // Creates a new ApplicationInstance for the target application identified by
+  // |params|. No resolution is done on the target URL and there must not be any
+  // existing instances for the given URL. Returns a pending ShellClientRequest
+  // for the instance.

[Ben Goodger (Google), 2016/02/25 03:02:58]

I'm wondering if we can make this method sound less general purpose and more
specific to this specific use case. i.e.

you are getting a ShellClientRequest for an initialization case where the params
describes the embedder.

InitInstanceForEmbedder()?

you should also ensure this only gets called once.

[Ken Rockot(use gerrit already), 2016/02/25 04:42:05]

sgtm and done

+  mojom::ShellClientRequest CreateInstanceForURL(
+      scoped_ptr<ConnectParams> params);
+
   // Sets the default Loader to be used if not overridden by SetLoaderForURL().
   void set_default_loader(scoped_ptr<ApplicationLoader> loader) {
     default_loader_ = std::move(loader);
   }
 
   // Sets a Loader to be used for a specific url.
   void SetLoaderForURL(scoped_ptr<ApplicationLoader> loader, const GURL& url);
 
   // Destroys all Shell-ends of connections established with Applications.
   // Applications connected by this ApplicationManager will observe pipe errors
@@ skipping 100 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ApplicationManager);
 };
 
 mojom::Shell::ConnectCallback EmptyConnectCallback();
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // MOJO_SHELL_APPLICATION_MANAGER_H_