Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1738653003: [interpreter] Remove wholesale skipping of strong mode tests. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_strong-remove-count
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Remove wholesale skipping of strong mode tests. By now the deprecation of strong mode is far enough along that the support present in the interpreter matches the support in the other compilers. Special expectations aren't needed anymore. R=rmcilroy@chromium.org Committed: https://crrev.com/ee4225fd0f8d36df1a173aac6a2df26245456599 Cr-Commit-Position: refs/heads/master@{#34293}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Remove more skips. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 chunks +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-25 11:49:32 UTC) #1
rmcilroy
LGTM once bots are happy.
4 years, 10 months ago (2016-02-25 12:07:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738653003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738653003/40001
4 years, 10 months ago (2016-02-25 13:45:42 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-25 13:49:33 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 13:51:04 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ee4225fd0f8d36df1a173aac6a2df26245456599
Cr-Commit-Position: refs/heads/master@{#34293}

Powered by Google App Engine
This is Rietveld 408576698