Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: src/interpreter/bytecode-array-builder.cc

Issue 1738653003: [interpreter] Remove wholesale skipping of strong mode tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_strong-remove-count
Patch Set: Remove more skips. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/bytecode-array-builder.h" 5 #include "src/interpreter/bytecode-array-builder.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 namespace interpreter { 10 namespace interpreter {
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
1461 } 1461 }
1462 } 1462 }
1463 1463
1464 1464
1465 // static 1465 // static
1466 Bytecode BytecodeArrayBuilder::BytecodeForStoreIC(LanguageMode language_mode) { 1466 Bytecode BytecodeArrayBuilder::BytecodeForStoreIC(LanguageMode language_mode) {
1467 switch (language_mode) { 1467 switch (language_mode) {
1468 case SLOPPY: 1468 case SLOPPY:
1469 return Bytecode::kStoreICSloppy; 1469 return Bytecode::kStoreICSloppy;
1470 case STRICT: 1470 case STRICT:
1471 case STRONG:
1471 return Bytecode::kStoreICStrict; 1472 return Bytecode::kStoreICStrict;
1472 case STRONG:
1473 UNIMPLEMENTED();
1474 default: 1473 default:
1475 UNREACHABLE(); 1474 UNREACHABLE();
1476 } 1475 }
1477 return static_cast<Bytecode>(-1); 1476 return static_cast<Bytecode>(-1);
1478 } 1477 }
1479 1478
1480 1479
1481 // static 1480 // static
1482 Bytecode BytecodeArrayBuilder::BytecodeForKeyedStoreIC( 1481 Bytecode BytecodeArrayBuilder::BytecodeForKeyedStoreIC(
1483 LanguageMode language_mode) { 1482 LanguageMode language_mode) {
1484 switch (language_mode) { 1483 switch (language_mode) {
1485 case SLOPPY: 1484 case SLOPPY:
1486 return Bytecode::kKeyedStoreICSloppy; 1485 return Bytecode::kKeyedStoreICSloppy;
1487 case STRICT: 1486 case STRICT:
1487 case STRONG:
1488 return Bytecode::kKeyedStoreICStrict; 1488 return Bytecode::kKeyedStoreICStrict;
1489 case STRONG:
1490 UNIMPLEMENTED();
1491 default: 1489 default:
1492 UNREACHABLE(); 1490 UNREACHABLE();
1493 } 1491 }
1494 return static_cast<Bytecode>(-1); 1492 return static_cast<Bytecode>(-1);
1495 } 1493 }
1496 1494
1497 1495
1498 // static 1496 // static
1499 Bytecode BytecodeArrayBuilder::BytecodeForLoadGlobal(TypeofMode typeof_mode) { 1497 Bytecode BytecodeArrayBuilder::BytecodeForLoadGlobal(TypeofMode typeof_mode) {
1500 return typeof_mode == INSIDE_TYPEOF ? Bytecode::kLdaGlobalInsideTypeof 1498 return typeof_mode == INSIDE_TYPEOF ? Bytecode::kLdaGlobalInsideTypeof
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1626 } 1624 }
1627 1625
1628 // static 1626 // static
1629 bool BytecodeArrayBuilder::FitsInReg16OperandUntranslated(Register value) { 1627 bool BytecodeArrayBuilder::FitsInReg16OperandUntranslated(Register value) {
1630 return value.is_short_operand(); 1628 return value.is_short_operand();
1631 } 1629 }
1632 1630
1633 } // namespace interpreter 1631 } // namespace interpreter
1634 } // namespace internal 1632 } // namespace internal
1635 } // namespace v8 1633 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698