Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 173853005: allowed keyed store callbacks ic generation (Closed)

Created:
6 years, 10 months ago by dcarney
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

allowed keyed store callbacks ic generation R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19744

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -78 lines) Patch
M src/a64/stub-cache-a64.cc View 1 4 chunks +13 lines, -12 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 3 chunks +12 lines, -11 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 chunks +13 lines, -12 lines 0 comments Download
M src/ic.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/stub-cache.h View 7 chunks +22 lines, -25 lines 0 comments Download
M src/stub-cache.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal
6 years, 10 months ago (2014-02-24 11:08:17 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-25 09:24:51 UTC) #2
dcarney
6 years, 9 months ago (2014-03-10 08:40:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698