Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: src/ic.cc

Issue 173853005: allowed keyed store callbacks ic generation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1335 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 1346
1347 Handle<Code> code = stub.GetCodeCopyFromTemplate( 1347 Handle<Code> code = stub.GetCodeCopyFromTemplate(
1348 isolate(), receiver->map(), *cell); 1348 isolate(), receiver->map(), *cell);
1349 // TODO(verwaest): Move caching of these NORMAL stubs outside as well. 1349 // TODO(verwaest): Move caching of these NORMAL stubs outside as well.
1350 HeapObject::UpdateMapCodeCache(receiver, name, code); 1350 HeapObject::UpdateMapCodeCache(receiver, name, code);
1351 return code; 1351 return code;
1352 } 1352 }
1353 ASSERT(holder.is_identical_to(receiver)); 1353 ASSERT(holder.is_identical_to(receiver));
1354 return isolate()->builtins()->StoreIC_Normal(); 1354 return isolate()->builtins()->StoreIC_Normal();
1355 case CALLBACKS: { 1355 case CALLBACKS: {
1356 if (kind() == Code::KEYED_STORE_IC) break;
1357 Handle<Object> callback(lookup->GetCallbackObject(), isolate()); 1356 Handle<Object> callback(lookup->GetCallbackObject(), isolate());
1358 if (callback->IsExecutableAccessorInfo()) { 1357 if (callback->IsExecutableAccessorInfo()) {
1359 Handle<ExecutableAccessorInfo> info = 1358 Handle<ExecutableAccessorInfo> info =
1360 Handle<ExecutableAccessorInfo>::cast(callback); 1359 Handle<ExecutableAccessorInfo>::cast(callback);
1361 if (v8::ToCData<Address>(info->setter()) == 0) break; 1360 if (v8::ToCData<Address>(info->setter()) == 0) break;
1362 if (!holder->HasFastProperties()) break; 1361 if (!holder->HasFastProperties()) break;
1363 if (!info->IsCompatibleReceiver(*receiver)) break; 1362 if (!info->IsCompatibleReceiver(*receiver)) break;
1364 return compiler.CompileStoreCallback(receiver, holder, name, info); 1363 return compiler.CompileStoreCallback(receiver, holder, name, info);
1365 } else if (callback->IsAccessorPair()) { 1364 } else if (callback->IsAccessorPair()) {
1366 Handle<Object> setter( 1365 Handle<Object> setter(
(...skipping 1451 matching lines...) Expand 10 before | Expand all | Expand 10 after
2818 #undef ADDR 2817 #undef ADDR
2819 }; 2818 };
2820 2819
2821 2820
2822 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2821 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2823 return IC_utilities[id]; 2822 return IC_utilities[id];
2824 } 2823 }
2825 2824
2826 2825
2827 } } // namespace v8::internal 2826 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698