Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1738483003: Move Request to its own file in preparation for numerous cleanups (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -28 lines) Patch
A tools/skiaserve/Request.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 2 2 chunks +3 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
joshualitt
ptal, after this I'm going to move some of Request's helpers out of skiaserve.cpp
4 years, 10 months ago (2016-02-25 15:03:50 UTC) #3
joshualitt
adding Joe
4 years, 10 months ago (2016-02-25 15:56:10 UTC) #6
ethannicholas
On 2016/02/25 15:03:50, joshualitt wrote: > ptal, after this I'm going to move some of ...
4 years, 10 months ago (2016-02-25 15:58:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738483003/20001
4 years, 10 months ago (2016-02-25 15:59:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/628)
4 years, 10 months ago (2016-02-25 16:00:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738483003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738483003/40001
4 years, 10 months ago (2016-02-25 16:22:06 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 16:37:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/24dd687ac5f7afb44d593d793180f115f7c68b68

Powered by Google App Engine
This is Rietveld 408576698