Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: content/test/

Issue 1738233002: Disallow was_within_same_page = true for a cross-process navigation (Closed) Base URL:
Patch Set: Fix is_navigation_within_page Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/
diff --git a/content/test/ b/content/test/
index 0b0a95396ed4f321140da5c8882ea00c78fd6a56..cb587ceaccd6b7deba1a6e1bdfaeeedd5d65e6a7 100644
--- a/content/test/
+++ b/content/test/
@@ -271,10 +271,12 @@ void TestRenderFrameHost::SendNavigateWithParameters(
ui::PageTransition transition,
int response_code,
const ModificationCallback& callback) {
+ if (!IsBrowserSideNavigationEnabled())
nasko 2016/03/01 00:27:01 Why is browser-side navigation different here?
gzobqq 2016/03/01 08:31:42 With browser-side navigation RFHI::OnDidStartLoadi
+ OnDidStartLoading(true);
// DidStartProvisionalLoad may delete the pending entry that holds |url|,
// so we keep a copy of it to use below.
GURL url_copy(url);
- OnDidStartLoading(true);
OnDidStartProvisionalLoad(url_copy, base::TimeTicks::Now());
FrameHostMsg_DidCommitProvisionalLoad_Params params;

Powered by Google App Engine
This is Rietveld 408576698