Disallow was_within_same_page = true for a cross-process navigation

content/test/test_render_frame_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/test_render_frame_host.h"
 
 #include "base/guid.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/navigation_handle_impl.h"
 #include "content/browser/frame_host/navigation_request.h"
@@ skipping 253 matching lines @@
 }
 
 void TestRenderFrameHost::SendNavigateWithParameters(
     int page_id,
     int nav_entry_id,
     bool did_create_new_entry,
     const GURL& url,
     ui::PageTransition transition,
     int response_code,
     const ModificationCallback& callback) {
+  if (!IsBrowserSideNavigationEnabled())

[nasko, 2016/03/01 00:27:01]

Why is browser-side navigation different here?

[gzobqq, 2016/03/01 08:31:42]

With browser-side navigation RFHI::OnDidStartLoading(true) does nothing but
ReceivedBadMessage(), which interferes with the new test. Renderer also sends
FrameHostMsg_DidStartLoading only when !IsBrowserSideNavigationEnabled() ||
!to_different_document. It was a recent change by clamy in
https://codereview.chromium.org/1608283002

+    OnDidStartLoading(true);
+
   // DidStartProvisionalLoad may delete the pending entry that holds |url|,
   // so we keep a copy of it to use below.
   GURL url_copy(url);
-  OnDidStartLoading(true);
   OnDidStartProvisionalLoad(url_copy, base::TimeTicks::Now());
 
   FrameHostMsg_DidCommitProvisionalLoad_Params params;
   params.page_id = page_id;
   params.nav_entry_id = nav_entry_id;
   params.url = url_copy;
   params.transition = transition;
   params.should_update_history = true;
   params.did_create_new_entry = did_create_new_entry;
   params.gesture = NavigationGestureUser;
@@ skipping 128 matching lines @@
   // cleared during DidFailProvisionalLoad).
   int page_id = entry ? entry->GetPageID() : -1;
   if (page_id == -1) {
     WebContentsImpl* web_contents = static_cast<WebContentsImpl*>(delegate());
     page_id = web_contents->GetMaxPageIDForSiteInstance(GetSiteInstance()) + 1;
   }
   return page_id;
 }
 
 }  // namespace content