Chromium Code Reviews
Help | Chromium Project | Sign in
(658)

Issue 17382007: Move IPC reception handling from AutofillManager to AutofillDriverImpl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 1 week ago by blundell (OOO until April 28)
Modified:
10 months ago
CC:
chromium-reviews_chromium.org, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, selim, benm
Visibility:
Public.

Description

Move IPC reception handling from AutofillManager to AutofillDriverImpl.

As AutofillManager will be shared by iOS, it should not receive IPC directly.
Instead, AutofillDriverImpl now handles IPC reception and forwards to
AutofillManager as appropriate.

Similarly, this CL also abstracts the content-level concepts of handling frame
navigation out of AutofillManager into AutofillDriverImpl.

BUG=247015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207726

Patch Set 1 #

Patch Set 2 : Rebase to fix conflicts #

Patch Set 3 : Rebase after conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -121 lines) Lint Patch
M components/autofill/content/browser/autofill_driver_impl.cc View 1 2 chunks +58 lines, -4 lines 0 comments 0 errors Download
M components/autofill/core/browser/autocomplete_history_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M components/autofill/core/browser/autofill_manager.h View 1 2 7 chunks +51 lines, -63 lines 0 comments ? errors Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 3 chunks +0 lines, -53 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 7
blundell (OOO until April 28)
I am currently working on bringing up unit tests of AutofillDriverImpl for a follow-up CL.
10 months, 1 week ago #1
Ilya Sherman
LGTM. It would be great to update the documentation for all of these methods, and ...
10 months, 1 week ago #2
blundell (OOO until April 28)
Agreed about the followup work re: updating documentation and reordering. Will do.
10 months, 1 week ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/17382007/4001
10 months, 1 week ago #4
I haz the power (commit-bot)
Commit queue failed due to new patchset.
10 months, 1 week ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/17382007/4002
10 months, 1 week ago #6
I haz the power (commit-bot)
10 months ago #7
Message was sent while issue was closed.
Change committed as 207726
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6