chrome/browser/ui/tabs/tab_strip_model_observer.h - Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_observer.h

Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't modify content Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model_observer.h

diff --git a/chrome/browser/ui/tabs/tab_strip_model_observer.h b/chrome/browser/ui/tabs/tab_strip_model_observer.h

index 52b656c365f5e37b88826f5ef2278b32f6fc6786..722cbbe4007a16fee81b5ed16f3dee6e6e37d5fd 100644

--- a/chrome/browser/ui/tabs/tab_strip_model_observer.h

+++ b/chrome/browser/ui/tabs/tab_strip_model_observer.h

@@ -71,7 +71,9 @@ class TabStripModelObserver {

// be inserted in another TabStripModel. The implementer should take whatever

// action is necessary to deal with the WebContents no longer being

// present.

- virtual void TabDetachedAt(content::WebContents* contents, int index);

+ virtual void TabDetachedAt(content::WebContents* contents,

+ int index,

+ bool closing_all);

Avi (use Gerrit) 2013/06/19 14:18:34 What does "closing_all" mean in this context? This

// The active WebContents is about to change from |old_contents|.

// This gives observers a chance to prepare for an impending switch before it