chrome/browser/ui/tabs/tab_strip_model.cc - Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't modify content Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc

index a550ca0eac4eb795918b20af92e459524c5ebfc8..f13a940af67c280663854b9968ee7fddfa7a6ede 100644

--- a/chrome/browser/ui/tabs/tab_strip_model.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model.cc

@@ -270,7 +270,7 @@ WebContents* TabStripModel::DetachWebContentsAt(int index) {

if (empty())

closing_all_ = true;

FOR_EACH_OBSERVER(TabStripModelObserver, observers_,

- TabDetachedAt(removed_contents, index));

+ TabDetachedAt(removed_contents, index, closing_all_));

if (empty()) {

selection_model_.Clear();

// TabDetachedAt() might unregister observers, so send |TabStripEmpty()| in