chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc - Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc

Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't modify content Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc

diff --git a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc

index f0caf47f7311b4ed9cf679e520d40df2a8d01434..435023702cd6eb8fd71acb97a9635bac352b4968 100644

--- a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc

+++ b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc

@@ -1042,7 +1042,9 @@ void TabStripGtk::TabInsertedAt(WebContents* contents,

ReStack();

}

-void TabStripGtk::TabDetachedAt(WebContents* contents, int index) {

+void TabStripGtk::TabDetachedAt(WebContents* contents,

+ int index,

+ bool closing_all) {

GenerateIdealBounds();

StartRemoveTabAnimation(index, contents);

// Have to do this _after_ calling StartRemoveTabAnimation, so that any