chrome/browser/ui/gtk/browser_window_gtk.cc - Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't modify content Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/browser_window_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc

index f343c44ecf2e4b762abb3a6a910fe559416d8ae5..c3b49ff13236d075e3f1710c7a30a866bf8e6277 100644

--- a/chrome/browser/ui/gtk/browser_window_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc

@@ -1198,7 +1198,9 @@ void BrowserWindowGtk::Observe(int type,

gtk_util::SetWindowIcon(window_, browser_->profile());

}

-void BrowserWindowGtk::TabDetachedAt(WebContents* contents, int index) {

+void BrowserWindowGtk::TabDetachedAt(WebContents* contents,

+ int index,

+ bool closing_all) {

// We use index here rather than comparing |contents| because by this time

// the model has already removed |contents| from its list, so

// browser_->tab_strip_model()->GetActiveWebContents() will return NULL or