Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3053)

Unified Diff: chrome/browser/extensions/browser_event_router.h

Issue 17382005: Unbreak tabs.onRemove extension API in face of fast tab closure Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't modify content Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_event_router.h
diff --git a/chrome/browser/extensions/browser_event_router.h b/chrome/browser/extensions/browser_event_router.h
index f424f57a66390043691581e8e697718eed15ebde..85ae520ffb7169b7345624ae4a7a1820b0971019 100644
--- a/chrome/browser/extensions/browser_event_router.h
+++ b/chrome/browser/extensions/browser_event_router.h
@@ -47,7 +47,8 @@ class BrowserEventRouter : public TabStripModelObserver,
content::WebContents* contents,
int index) OVERRIDE;
virtual void TabDetachedAt(content::WebContents* contents,
- int index) OVERRIDE;
+ int index,
+ bool closing_all) OVERRIDE;
virtual void ActiveTabChanged(content::WebContents* old_contents,
content::WebContents* new_contents,
int index,
@@ -130,6 +131,15 @@ class BrowserEventRouter : public TabStripModelObserver,
void DispatchTabUpdatedEvent(content::WebContents* contents,
scoped_ptr<DictionaryValue> changed_properties);
+ void DispatchTabDetached(content::WebContents* contents, int index);
+
+ // Send Tab removed event and stop listening for notifications on said
+ // |contents|.
+ void DispatchTabRemovedAndUnregisterNotifications(
+ content::WebContents* contents,
+ int tab_id,
+ bool window_closing);
+
// Called to dispatch a deprecated style page action click event that was
// registered like:
// chrome.pageActions["name"].addListener(function(actionId, info){})

Powered by Google App Engine
This is Rietveld 408576698