Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 17381009: Move io_surface_support_mac to ui/gl. (Closed)

Created:
7 years, 6 months ago by danakj
Modified:
7 years, 6 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, backer
Visibility:
Public.

Description

Move io_surface_support_mac to ui/gl. This removes a dependency on media/ via ui/surface from gpu.gyp, allowing media to use gpu.gyp for gpu::Mailbox. R=piman@chromium.org, sky@chromium.org BUG=179729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207129

Patch Set 1 : ui-gyp: macfix #

Patch Set 2 : ui-gyp: fixmacmore #

Patch Set 3 : ui-gyp: fixbuild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -394 lines) Patch
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/gl/io_surface_support_mac.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
A + ui/gl/io_surface_support_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/surface/accelerated_surface_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D ui/surface/io_surface_support_mac.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ui/surface/io_surface_support_mac.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M ui/surface/surface.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
danakj
7 years, 6 months ago (2013-06-18 21:12:43 UTC) #1
piman
LGTM in principle, but, aren't there callers of this that need to be updated?
7 years, 6 months ago (2013-06-18 21:25:51 UTC) #2
danakj
On Tue, Jun 18, 2013 at 5:25 PM, <piman@chromium.org> wrote: > LGTM in principle, but, ...
7 years, 6 months ago (2013-06-18 21:28:09 UTC) #3
danakj
Ok, this patch set build locally on mac.
7 years, 6 months ago (2013-06-18 22:06:00 UTC) #4
danakj
+sky for chrome/ OWNERS
7 years, 6 months ago (2013-06-18 22:06:26 UTC) #5
piman
lgtm
7 years, 6 months ago (2013-06-18 22:12:24 UTC) #6
danakj
Oh, sky@ PTAL at the whole CL not just chrome/. You are also owners for ...
7 years, 6 months ago (2013-06-18 22:26:16 UTC) #7
sky
LGTM
7 years, 6 months ago (2013-06-19 00:27:02 UTC) #8
danakj
Thanks :)
7 years, 6 months ago (2013-06-19 00:29:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17381009/2003
7 years, 6 months ago (2013-06-19 00:30:27 UTC) #10
danakj
7 years, 6 months ago (2013-06-19 00:48:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 manually as r207129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698