OOP import on Linux (i.e., on all platforms since Linux is the only one left!).

OOP import on Linux (i.e., on all platforms since Linux is the only one left!).

After this CL the only blocker to completely remove the in-process import code will be the toolbar importer on Windows (http://crbug.com/243423).

BUG=56816
TEST=Manually verify that first run import works (i.e. imports FF history when FF is default) on Linux.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208054

[gab, 2013-06-19 20:06:03]

Miranda, it's my pleasure to present you OOP import on Linux, woo woo :)!

Cheers,
Gab

https://codereview.chromium.org/17379006/diff/22001/chrome/browser/importer/e...
File chrome/browser/importer/external_process_importer_client.cc (right):

https://codereview.chromium.org/17379006/diff/22001/chrome/browser/importer/e...
chrome/browser/importer/external_process_importer_client.cc:67: DLOG(ERROR) <<
__FUNCTION__;
Also adding this as it helped me when debugging to know that the issue at some
point was the utility process crashing.

[Miranda Callahan, 2013-06-19 20:20:17]

On 2013/06/19 20:06:03, gab wrote:
> Miranda, it's my pleasure to present you OOP import on Linux, woo woo :)!
> 
> Cheers,
> Gab
> 
>
https://codereview.chromium.org/17379006/diff/22001/chrome/browser/importer/e...
> File chrome/browser/importer/external_process_importer_client.cc (right):
> 
>
https://codereview.chromium.org/17379006/diff/22001/chrome/browser/importer/e...
> chrome/browser/importer/external_process_importer_client.cc:67: DLOG(ERROR) <<
> __FUNCTION__;
> Also adding this as it helped me when debugging to know that the issue at some
> point was the utility process crashing.

Great that it's to the point where it all just falls together -- LGTM!

[commit-bot: I haz the power, 2013-06-20 19:12:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17379006/22001

[commit-bot: I haz the power, 2013-06-20 19:31:05]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[gab, 2013-06-20 21:11:01]

+Jeffrey for OWNER on chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+Even for on chrome/browser/ui/webui/options/import_data_handler.cc

Thanks!
Gab

[gab, 2013-06-20 21:11:18]

On 2013/06/20 21:11:01, gab wrote:
> +Jeffrey for OWNER on chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
> +Even for on chrome/browser/ui/webui/options/import_data_handler.cc
s/Even/Evan :)!

> 
> Thanks!
> Gab

[Jeffrey Yasskin, 2013-06-21 18:45:37]

extensions lgtm

[gab, 2013-06-21 18:49:36]

Thanks,

@estade for OWNER on chrome/browser/ui/webui/options/import_data_handler.cc

Cheers,
Gab

[Evan Stade, 2013-06-21 19:34:22]

chrome/browser/ui/webui/options/import_data_handler.cc lgtm

[commit-bot: I haz the power, 2013-06-21 20:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17379006/22001

[commit-bot: I haz the power, 2013-06-22 02:40:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17379006/22001

[commit-bot: I haz the power, 2013-06-22 03:05:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17379006/22001

[commit-bot: I haz the power, 2013-06-22 03:33:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17379006/22001

[commit-bot: I haz the power, 2013-06-22 03:41:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/17379006/22001

[commit-bot: I haz the power, 2013-06-22 15:10:27]

Change committed as 208054