chrome/browser/importer/firefox_importer_browsertest.cc - Issue 17379006: OOP import on Linux (i.e., on all platforms since Linux is the only one left!).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/firefox_importer_browsertest.cc

Issue 17379006: OOP import on Linux (i.e., on all platforms since Linux is the only one left!). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/importer/external_process_importer_client.cc ('K') | « chrome/browser/importer/external_process_importer_client.cc ('k') | chrome/browser/ui/webui/options/import_data_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/firefox_importer_browsertest.cc

diff --git a/chrome/browser/importer/firefox_importer_browsertest.cc b/chrome/browser/importer/firefox_importer_browsertest.cc

index c58f13eae7fecdcd81c4016e3cdd6074e8b6b7bd..f2f57c9b70fa165d064a401c5dbcb18dce34f42e 100644

--- a/chrome/browser/importer/firefox_importer_browsertest.cc

+++ b/chrome/browser/importer/firefox_importer_browsertest.cc

@@ -269,13 +269,7 @@ class FirefoxProfileImporterBrowserTest : public InProcessBrowserTest {

items = items | importer::SEARCH_ENGINES;

// Deletes itself.

- // TODO(gab): Use ExternalProcessImporterHost on Linux as well.

- ImporterHost* host;

-#if defined(OS_MACOSX) || defined(OS_WIN)

- host = new ExternalProcessImporterHost;

-#else

- host = new ImporterHost;

-#endif

+ ImporterHost* host = new ExternalProcessImporterHost;

host->SetObserver(observer);

host->StartImportSettings(source_profile, browser()->profile(),

items, make_scoped_refptr(writer));