Change type of SkGlyph::fAdvance[XY] to float.

Change type of SkGlyph::fAdvance[XY] to float.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737693006

Committed: https://skia.googlesource.com/skia/+/6b3eacb0dfaeb3374d410c8c041bd39cd066e1ea

[dogben, 2016-02-26 20:54:09]

Description was changed from

==========
Change type of SkGlyph::fAdvance[XY] to float.

BUG=skia:4632
==========

to

==========
Change type of SkGlyph::fAdvance[XY] to float.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-02-26 20:55:14]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 20:55:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/1

[commit-bot: I haz the power, 2016-02-26 20:58:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:58:02]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[dogben, 2016-02-26 21:15:24]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 21:15:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/20001

[commit-bot: I haz the power, 2016-02-26 21:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 21:32:52]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-02-26 21:56:17]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 21:56:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/40001

[commit-bot: I haz the power, 2016-02-26 21:58:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 21:58:55]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[dogben, 2016-02-26 22:00:55]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 22:01:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/60001

[commit-bot: I haz the power, 2016-02-26 22:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 22:21:15]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-02-26 22:28:44]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 22:28:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/80001

[commit-bot: I haz the power, 2016-02-26 22:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 22:42:55]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-01 14:38:59]

benjaminwagner@google.com changed reviewers:
+ bungeman@google.com

[dogben, 2016-03-01 14:39:00]

Can you take a look at the diffs on Gold? The biggest diffs seem to be due to
the floor here:
https://skia.googlesource.com/skia/+/819ab1028897c7ae8ea07cb342d48118d29daa5d...

I think I understand what's going on, and I don't think it's a problem with my
change, but I don't quite understand *why* it works this way.

[dogben, 2016-03-11 16:49:32]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 16:49:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/80001

[commit-bot: I haz the power, 2016-03-11 17:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 17:02:55]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-22 21:38:04]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 21:38:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/80001

[commit-bot: I haz the power, 2016-03-22 21:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 21:54:41]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-23 17:47:46]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[dogben, 2016-03-23 17:47:52]

Patchset #5 (id:80001) has been deleted

[dogben, 2016-03-23 17:47:56]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-03-23 17:47:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/100001

[dogben, 2016-03-23 17:48:00]

Patchset #3 (id:40001) has been deleted

[dogben, 2016-03-23 17:48:04]

Patchset #2 (id:20001) has been deleted

[dogben, 2016-03-23 17:48:11]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-03-23 18:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 18:05:21]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-23 18:08:44]

I've convinced myself that full-pixel aligned glyphs just intrinsically look
goofy with rotation. The Gold diffs seem OK to me. Happy to discuss.

[bungeman-skia, 2016-03-24 15:58:37]

https://codereview.chromium.org/1737693006/diff/100001/src/ports/SkFontHost_m...
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/1737693006/diff/100001/src/ports/SkFontHost_m...
src/ports/SkFontHost_mac.cpp:1045: glyph->fAdvanceX =  cgAdvance.width;
Might want to use something like CGToScalar here, though this is actually
CGToFloat (CGFloat is almost always double these days).

[dogben, 2016-03-24 16:54:03]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 16:54:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/120001

[bungeman-skia, 2016-03-24 17:03:05]

lgtm

[dogben, 2016-03-24 17:08:12]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 17:08:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/140001

[commit-bot: I haz the power, 2016-03-24 17:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 17:24:29]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-24 18:12:35]

On 2016/03/24 at 15:58:37, bungeman wrote:
>
https://codereview.chromium.org/1737693006/diff/100001/src/ports/SkFontHost_m...
> File src/ports/SkFontHost_mac.cpp (right):
> 
>
https://codereview.chromium.org/1737693006/diff/100001/src/ports/SkFontHost_m...
> src/ports/SkFontHost_mac.cpp:1045: glyph->fAdvanceX =  cgAdvance.width;
> Might want to use something like CGToScalar here, though this is actually
CGToFloat (CGFloat is almost always double these days).

Done, PTAL.

[dogben, 2016-03-25 02:06:38]

The CQ bit was checked by benjaminwagner@google.com

[dogben, 2016-03-25 02:06:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1737693006/#ps140001
(title: "Should be float, not SkScalar.")

[commit-bot: I haz the power, 2016-03-25 02:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737693006/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737693006/140001

[commit-bot: I haz the power, 2016-03-25 02:08:03]

Description was changed from

==========
Change type of SkGlyph::fAdvance[XY] to float.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change type of SkGlyph::fAdvance[XY] to float.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6b3eacb0dfaeb3374d410c8c041bd39cd066e1ea
==========

[commit-bot: I haz the power, 2016-03-25 02:08:05]

Committed patchset #3 (id:140001) as
https://skia.googlesource.com/skia/+/6b3eacb0dfaeb3374d410c8c041bd39cd066e1ea