src/ports/SkScalerContext_win_dw.cpp - Issue 1737693006: Change type of SkGlyph::fAdvance[XY] to float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkScalerContext_win_dw.cpp

Issue 1737693006: Change type of SkGlyph::fAdvance[XY] to float. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Should be float, not SkScalar. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkScalerContext_win_dw.cpp

diff --git a/src/ports/SkScalerContext_win_dw.cpp b/src/ports/SkScalerContext_win_dw.cpp

index 097db865e19210eaf1e78a7391816eb91ffa14d4..f276762bbfae666d0a7d2b9f1ce25c059f33cb6a 100644

--- a/src/ports/SkScalerContext_win_dw.cpp

+++ b/src/ports/SkScalerContext_win_dw.cpp

@@ -388,8 +388,8 @@ void SkScalerContext_DW::generateAdvance(SkGlyph* glyph) {

fSkXform.mapVectors(vecs, SK_ARRAY_COUNT(vecs));

}

- glyph->fAdvanceX = SkScalarToFixed(vecs[0].fX);

- glyph->fAdvanceY = SkScalarToFixed(vecs[0].fY);

+ glyph->fAdvanceX = SkScalarToFloat(vecs[0].fX);

+ glyph->fAdvanceY = SkScalarToFloat(vecs[0].fY);

}

HRESULT SkScalerContext_DW::getBoundingBox(SkGlyph* glyph,

« no previous file with comments | « src/ports/SkFontHost_win.cpp ('k') | no next file » | no next file with comments »