Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4318)

Unified Diff: chrome/browser/origin_trials/origin_trial_controller_unittest.cc

Issue 1737693002: Allow command-line arguments to override EF public key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback from PS#4 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/origin_trials/origin_trial_controller_unittest.cc
diff --git a/chrome/browser/origin_trials/origin_trial_controller_unittest.cc b/chrome/browser/origin_trials/origin_trial_controller_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b3b17dfdfb471a68382932216cfd682c9cd44bb8
--- /dev/null
+++ b/chrome/browser/origin_trials/origin_trial_controller_unittest.cc
@@ -0,0 +1,78 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/origin_trials/origin_trial_controller.h"
+
+#include <string>
+
+#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/common/chrome_switches.h"
+#include "components/variations/variations_associated_data.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+const char kFieldTrialGroup[] = "TestGroup";
+const char kNewPublicKey[] = "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=";
+
+class OriginTrialControllerTest : public testing::Test {
+ protected:
+ OriginTrialControllerTest()
+ : command_line_(base::CommandLine::NO_PROGRAM),
+ field_trial_list_(nullptr /* entropy provider */) {
+ variations::testing::ClearAllVariationParams();
+ }
+
+ void AddFieldTrial() {
+ base::FieldTrialList::CreateFieldTrial(
+ OriginTrialController::kFieldTrialName, kFieldTrialGroup);
+ }
+
+ void AddFieldTrialParam(const char* param_name, const char* param_value) {
+ std::map<std::string, std::string> variation_params;
+ variation_params[param_name] = param_value;
+ ASSERT_TRUE(variations::AssociateVariationParams(
+ OriginTrialController::kFieldTrialName, kFieldTrialGroup,
+ variation_params));
+ }
+
+ void UpdateCommandLine() {
+ command_line_ = base::CommandLine(base::CommandLine::NO_PROGRAM);
+ OriginTrialController::UpdateCommandLineFromFieldTrials(command_line());
+ }
+
+ base::CommandLine* command_line() { return &command_line_; }
+
+ private:
+ base::CommandLine command_line_;
+ base::FieldTrialList field_trial_list_;
+
+ DISALLOW_COPY_AND_ASSIGN(OriginTrialControllerTest);
+};
+
+TEST_F(OriginTrialControllerTest, NoFieldTrial) {
+ UpdateCommandLine();
+ EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
+}
+
+TEST_F(OriginTrialControllerTest, EmptyFieldTrial) {
+ AddFieldTrial();
+ UpdateCommandLine();
+ EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
+}
+
+TEST_F(OriginTrialControllerTest, EmptyStringFieldTrial) {
+ AddFieldTrial();
+ AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, "");
+ UpdateCommandLine();
+ EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
+}
+
+TEST_F(OriginTrialControllerTest, FieldTrialUpdatesPublicKey) {
+ AddFieldTrial();
+ AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, kNewPublicKey);
+ UpdateCommandLine();
+ EXPECT_TRUE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
+ EXPECT_EQ(kNewPublicKey, command_line()->GetSwitchValueASCII(
+ switches::kOriginTrialPublicKey));
+}

Powered by Google App Engine
This is Rietveld 408576698