Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/origin_trials/origin_trial_controller_unittest.cc

Issue 1737693002: Allow command-line arguments to override EF public key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback from PS#4 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/origin_trials/origin_trial_controller.h"
6
7 #include <string>
8
9 #include "base/command_line.h"
10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/common/chrome_switches.h"
12 #include "components/variations/variations_associated_data.h"
13 #include "testing/gtest/include/gtest/gtest.h"
14
15 const char kFieldTrialGroup[] = "TestGroup";
16 const char kNewPublicKey[] = "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=";
17
18 class OriginTrialControllerTest : public testing::Test {
19 protected:
20 OriginTrialControllerTest()
21 : command_line_(base::CommandLine::NO_PROGRAM),
22 field_trial_list_(nullptr /* entropy provider */) {
23 variations::testing::ClearAllVariationParams();
24 }
25
26 void AddFieldTrial() {
27 base::FieldTrialList::CreateFieldTrial(
28 OriginTrialController::kFieldTrialName, kFieldTrialGroup);
29 }
30
31 void AddFieldTrialParam(const char* param_name, const char* param_value) {
32 std::map<std::string, std::string> variation_params;
33 variation_params[param_name] = param_value;
34 ASSERT_TRUE(variations::AssociateVariationParams(
35 OriginTrialController::kFieldTrialName, kFieldTrialGroup,
36 variation_params));
37 }
38
39 void UpdateCommandLine() {
40 command_line_ = base::CommandLine(base::CommandLine::NO_PROGRAM);
41 OriginTrialController::UpdateCommandLineFromFieldTrials(command_line());
42 }
43
44 base::CommandLine* command_line() { return &command_line_; }
45
46 private:
47 base::CommandLine command_line_;
48 base::FieldTrialList field_trial_list_;
49
50 DISALLOW_COPY_AND_ASSIGN(OriginTrialControllerTest);
51 };
52
53 TEST_F(OriginTrialControllerTest, NoFieldTrial) {
54 UpdateCommandLine();
55 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
56 }
57
58 TEST_F(OriginTrialControllerTest, EmptyFieldTrial) {
59 AddFieldTrial();
60 UpdateCommandLine();
61 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
62 }
63
64 TEST_F(OriginTrialControllerTest, EmptyStringFieldTrial) {
65 AddFieldTrial();
66 AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, "");
67 UpdateCommandLine();
68 EXPECT_FALSE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
69 }
70
71 TEST_F(OriginTrialControllerTest, FieldTrialUpdatesPublicKey) {
72 AddFieldTrial();
73 AddFieldTrialParam(OriginTrialController::kPublicKeyFieldName, kNewPublicKey);
74 UpdateCommandLine();
75 EXPECT_TRUE(command_line()->HasSwitch(switches::kOriginTrialPublicKey));
76 EXPECT_EQ(kNewPublicKey, command_line()->GetSwitchValueASCII(
77 switches::kOriginTrialPublicKey));
78 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698