chrome/renderer/origin_trials/origin_trial_key_manager.h - Issue 1737693002: Allow command-line arguments to override EF public key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/origin_trials/origin_trial_key_manager.h

Issue 1737693002: Allow command-line arguments to override EF public key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments from PS#1 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/origin_trials/origin_trial_key_manager.cc » ('j') | chrome/renderer/origin_trials/origin_trial_key_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/origin_trials/origin_trial_key_manager.h

diff --git a/chrome/renderer/origin_trials/origin_trial_key_manager.h b/chrome/renderer/origin_trials/origin_trial_key_manager.h

index 18b01d841a82a93fcbd1e94f17b89d25b96b550d..5f01b50aa3e2788f8395b5fff79ae57c3dc46963 100644

--- a/chrome/renderer/origin_trials/origin_trial_key_manager.h

+++ b/chrome/renderer/origin_trials/origin_trial_key_manager.h

@@ -5,11 +5,19 @@

#ifndef CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

#define CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

+#include <string>

#include "base/strings/string_piece.h"

class OriginTrialKeyManager {

public:

- base::StringPiece GetPublicKey();

+ OriginTrialKeyManager();

+ ~OriginTrialKeyManager();

Alexei Svitkine (slow) 2016/02/26 16:29:08 Nit: Add empty line below.

iclelland 2016/02/26 19:55:04 Done.

+ bool SetPublicKeyFromASCIIString(const std::string& ascii_public_key);

+ base::StringPiece GetPublicKey() const;

+ private:

+ std::string public_key_;

};

Alexei Svitkine (slow) 2016/02/26 16:29:08 Nit: DISALLOW_COPY_AND_ASSIGN()

iclelland 2016/02/26 19:55:04 Done. Thanks.

#endif // CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_