chrome/renderer/origin_trials/origin_trial_key_manager.h - Issue 1737693002: Allow command-line arguments to override EF public key

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/origin_trials/origin_trial_key_manager.h

Issue 1737693002: Allow command-line arguments to override EF public key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments from PS#1 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/origin_trials/origin_trial_key_manager.cc » ('j') | chrome/renderer/origin_trials/origin_trial_key_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_	5 #ifndef CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

6 #define CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_	6 #define CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

7	7

	8 #include <string>

	9

8 #include "base/strings/string_piece.h"	10 #include "base/strings/string_piece.h"

9	11

10 class OriginTrialKeyManager {	12 class OriginTrialKeyManager {

11 public:	13 public:

12 base::StringPiece GetPublicKey();	14 OriginTrialKeyManager();

	15 ~OriginTrialKeyManager();
	Alexei Svitkine (slow) 2016/02/26 16:29:08 Nit: Add empty line below. Nit: Add empty line below. iclelland 2016/02/26 19:55:04 Done. Show quoted text On 2016/02/26 16:29:08, Alexei Svitkine (slow) wrote: > Nit: Add empty line below. Done.
	16 bool SetPublicKeyFromASCIIString(const std::string& ascii_public_key);

	17 base::StringPiece GetPublicKey() const;

	18

	19 private:

	20 std::string public_key_;

13 };	21 };
	Alexei Svitkine (slow) 2016/02/26 16:29:08 Nit: DISALLOW_COPY_AND_ASSIGN() Nit: DISALLOW_COPY_AND_ASSIGN() iclelland 2016/02/26 19:55:04 Done. Thanks. Show quoted text On 2016/02/26 16:29:08, Alexei Svitkine (slow) wrote: > Nit: DISALLOW_COPY_AND_ASSIGN() Done. Thanks.
14	22

15 #endif // CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_	23 #endif // CHROME_RENDERER_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

OLD	NEW