Source/bindings/v8/Dictionary.cpp - Issue 173753002: Drop redundant 'ExceptionMessages::failedToXXX' calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 173753002: Drop redundant 'ExceptionMessages::failedToXXX' calls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebaseline. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/Dictionary.cpp

diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp

index 8fd6b183853f55c3e7d1f1474ad397d930383693..57313d3477459b53bd38df5f5828efa034c3bea1 100644

--- a/Source/bindings/v8/Dictionary.cpp

+++ b/Source/bindings/v8/Dictionary.cpp

@@ -750,12 +750,7 @@ Dictionary::ConversionContext& Dictionary::ConversionContext::setConversionType(

void Dictionary::ConversionContext::throwTypeError(const String& detail)

{

- if (forConstructor()) {

- exceptionState().throwTypeError(detail);

- } else {

- ASSERT(!methodName().isEmpty());

- exceptionState().throwTypeError(ExceptionMessages::failedToExecute(interfaceName(), methodName(), detail));

- }

+ exceptionState().throwTypeError(detail);

}

} // namespace WebCore