Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: Source/bindings/v8/Dictionary.cpp

Issue 173753002: Drop redundant 'ExceptionMessages::failedToXXX' calls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 732 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 ASSERT(!m_dirty); 743 ASSERT(!m_dirty);
744 m_dirty = true; 744 m_dirty = true;
745 m_isNullable = isNullable; 745 m_isNullable = isNullable;
746 m_propertyTypeName = typeName; 746 m_propertyTypeName = typeName;
747 747
748 return *this; 748 return *this;
749 } 749 }
750 750
751 void Dictionary::ConversionContext::throwTypeError(const String& detail) 751 void Dictionary::ConversionContext::throwTypeError(const String& detail)
752 { 752 {
753 if (forConstructor()) { 753 exceptionState().throwTypeError(detail);
754 exceptionState().throwTypeError(detail);
755 } else {
756 ASSERT(!methodName().isEmpty());
757 exceptionState().throwTypeError(ExceptionMessages::failedToExecute(inter faceName(), methodName(), detail));
758 }
759 } 754 }
760 755
761 } // namespace WebCore 756 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698