Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1737453003: Revert of Reland: No longer start up profile if there was an error fetching policy. (Closed)

Created:
4 years, 10 months ago by stevenjb
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: No longer start up profile if there was an error fetching policy. (patchset #1 id:1 of https://codereview.chromium.org/1727413002/ ) Reason for revert: Still causing failures here: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Lumpy%20%28chrome%29/builds/18722 It's possible that the telemetry fixes have not propagated to the builder yet. Original issue's description: > Reland: No longer start up profile if there was an error fetching policy. > > Changed UserCloudPolicyManagerChromeOS to no longer complete profile > initialization if there is an error fetching policy. Instead, we shutdown the > user and force a policy load the next time we try to startup that user. > > BUG=532317 > TBR=vitalybuka@chromium.org > > Committed: https://crrev.com/01a589c605a9ead2754a51a5ef2c916361c6be0d > Cr-Commit-Position: refs/heads/master@{#377288} TBR=vitalybuka@chromium.org,tnagel@google.com,atwilson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=532317 Committed: https://crrev.com/6c9db5f91e463b362258634356f4d3bca897f0ef Cr-Commit-Position: refs/heads/master@{#377371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -216 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/affiliation_test_helper.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/login_policy_test_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h View 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 9 chunks +14 lines, -51 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 3 chunks +0 lines, -66 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 2 chunks +8 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_test_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_test_helper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/policy/test/policy_testserver.py View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/policy/core/browser/browser_policy_connector.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
stevenjb
Created Revert of Reland: No longer start up profile if there was an error fetching ...
4 years, 10 months ago (2016-02-24 20:27:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737453003/1
4 years, 10 months ago (2016-02-24 20:35:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 20:42:27 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 20:44:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c9db5f91e463b362258634356f4d3bca897f0ef
Cr-Commit-Position: refs/heads/master@{#377371}

Powered by Google App Engine
This is Rietveld 408576698