chrome/browser/chromeos/policy/blocking_login_browsertest.cc - Issue 1737453003: Revert of Reland: No longer start up profile if there was an error fetching policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/blocking_login_browsertest.cc

Issue 1737453003: Revert of Reland: No longer start up profile if there was an error fetching policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/affiliation_test_helper.cc ('k') | chrome/browser/chromeos/policy/login_policy_test_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/blocking_login_browsertest.cc

diff --git a/chrome/browser/chromeos/policy/blocking_login_browsertest.cc b/chrome/browser/chromeos/policy/blocking_login_browsertest.cc

index 651a9264acc7c0cea5feaf70f30fc7d67a20f02f..a57f3ac2312e522368628165ad5fef6d5a46fd26 100644

--- a/chrome/browser/chromeos/policy/blocking_login_browsertest.cc

+++ b/chrome/browser/chromeos/policy/blocking_login_browsertest.cc

@@ -81,11 +81,6 @@

const bool enroll_device;

};

-// TODO(atwilson): This test is completely broken - it originally was built

-// when we made an entirely different set of network calls on startup. As a

-// result it generates random failures in startup network requests, then waits

-// to see if the profile finishes loading which is not at all what it is

-// intended to test. We need to fix this test or remove it (crbug.com/580537).

class BlockingLoginTest

: public OobeBaseTest,

public content::NotificationObserver,

@@ -100,9 +95,6 @@

command_line->AppendSwitchASCII(

policy::switches::kDeviceManagementUrl,

embedded_test_server()->GetURL("/device_management").spec());

- command_line->AppendSwitch(

- chromeos::switches::kAllowFailedPolicyFetchForTest);

}

void SetUpOnMainThread() override {