Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_win.cc

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_sensors/data_fetcher_shared_memory_win.cc
diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_win.cc b/content/browser/device_sensors/data_fetcher_shared_memory_win.cc
index 709c25b595c2b791df6ea7733f8828f47ba4c690..142de2cf47514f7efbb5c226ffcc2e19f05dbb85 100644
--- a/content/browser/device_sensors/data_fetcher_shared_memory_win.cc
+++ b/content/browser/device_sensors/data_fetcher_shared_memory_win.cc
@@ -130,7 +130,6 @@ class DataFetcherSharedMemory::SensorEventSinkOrientation
buffer_->data.gamma = gamma;
buffer_->data.hasGamma = has_gamma;
buffer_->data.absolute = true;
- buffer_->data.hasAbsolute = has_alpha || has_beta || has_gamma;
philipj_slow 2016/02/26 03:54:01 Same as for Android, do you think I should make th
timvolodine 2016/03/01 22:36:25 the spec doesn't really specify the value of absol
philipj_slow 2016/03/02 07:30:42 This data comes directly from ISensorDataReport an
buffer_->data.allAvailableSensorsAreActive = true;
buffer_->seqlock.WriteEnd();
}

Powered by Google App Engine
This is Rietveld 408576698