Make DeviceOrientationEvent.prototype.absolute non-nullable

components/test_runner/test_runner.cc

Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 1c63ef632cb4d6bf4e175a107376bd43963c48f3..88c892e50c23a23c1fa37570ce1406031eb6fd57 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -994,7 +994,6 @@ void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) {
   double beta = 0.0;
   bool has_gamma = false;
   double gamma = 0.0;
-  bool has_absolute = false;
   bool absolute = false;
 
   args->GetNext(&has_alpha);
@@ -1003,13 +1002,12 @@ void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) {
   args->GetNext(&beta);
   args->GetNext(&has_gamma);
   args->GetNext(&gamma);
-  args->GetNext(&has_absolute);
   args->GetNext(&absolute);

[timvolodine, 2016/03/01 22:46:01]

oh hold on, actually don't think this is fixed in all layout tests, e.g.
WebKit/LayoutTests/fast/dom/DeviceOrientation/resources/basic-operation.js
still invokes testRunner.setMockDeviceOrientation with all parameters.
Interestingly the tests still seem to pass probably because we always use
absolute=true as mock value.

Basically all calls to testRunner.setMockDeviceOrientation in layout tests need
to be updated..

[philipj_slow, 2016/03/02 07:30:42]

Oops. I've updated the other instances, and indeed they were all passing true as
the final two arguments.

 
   runner_->SetMockDeviceOrientation(has_alpha, alpha,
                                     has_beta, beta,
                                     has_gamma, gamma,
-                                    has_absolute, absolute);
+                                    absolute);
 }
 
 void TestRunnerBindings::SetMockScreenOrientation(
@@ -2533,7 +2531,7 @@ void TestRunner::SetMockDeviceMotion(
 void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha,
                                           bool has_beta, double beta,
                                           bool has_gamma, double gamma,
-                                          bool has_absolute, bool absolute) {
+                                          bool absolute) {
   WebDeviceOrientationData orientation;
 
   // alpha
@@ -2549,7 +2547,6 @@ void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha,
   orientation.gamma = gamma;
 
   // absolute
-  orientation.hasAbsolute = has_absolute;
   orientation.absolute = absolute;
 
   delegate_->SetDeviceOrientationData(orientation);