Make DeviceOrientationEvent.prototype.absolute non-nullable

components/test_runner/test_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/test_runner.h"
 
 #include <stddef.h>
 #include <limits>
 #include <utility>
 
@@ skipping 976 matching lines @@
 void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) {
   if (!runner_)
     return;
 
   bool has_alpha = false;
   double alpha = 0.0;
   bool has_beta = false;
   double beta = 0.0;
   bool has_gamma = false;
   double gamma = 0.0;
-  bool has_absolute = false;
   bool absolute = false;
 
   args->GetNext(&has_alpha);
   args->GetNext(&alpha);
   args->GetNext(&has_beta);
   args->GetNext(&beta);
   args->GetNext(&has_gamma);
   args->GetNext(&gamma);
-  args->GetNext(&has_absolute);
   args->GetNext(&absolute);

[timvolodine, 2016/03/01 22:46:01]

oh hold on, actually don't think this is fixed in all layout tests, e.g.
WebKit/LayoutTests/fast/dom/DeviceOrientation/resources/basic-operation.js
still invokes testRunner.setMockDeviceOrientation with all parameters.
Interestingly the tests still seem to pass probably because we always use
absolute=true as mock value.

Basically all calls to testRunner.setMockDeviceOrientation in layout tests need
to be updated..

[philipj_slow, 2016/03/02 07:30:42]

Oops. I've updated the other instances, and indeed they were all passing true as
the final two arguments.

 
   runner_->SetMockDeviceOrientation(has_alpha, alpha,
                                     has_beta, beta,
                                     has_gamma, gamma,
-                                    has_absolute, absolute);
+                                    absolute);
 }
 
 void TestRunnerBindings::SetMockScreenOrientation(
     const std::string& orientation) {
   if (!runner_)
     return;
 
   runner_->SetMockScreenOrientation(orientation);
 }
 
@@ skipping 1503 matching lines @@
 
   // interval
   motion.interval = interval;
 
   delegate_->SetDeviceMotionData(motion);
 }
 
 void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha,
                                           bool has_beta, double beta,
                                           bool has_gamma, double gamma,
-                                          bool has_absolute, bool absolute) {
+                                          bool absolute) {
   WebDeviceOrientationData orientation;
 
   // alpha
   orientation.hasAlpha = has_alpha;
   orientation.alpha = alpha;
 
   // beta
   orientation.hasBeta = has_beta;
   orientation.beta = beta;
 
   // gamma
   orientation.hasGamma = has_gamma;
   orientation.gamma = gamma;
 
   // absolute
-  orientation.hasAbsolute = has_absolute;
   orientation.absolute = absolute;
 
   delegate_->SetDeviceOrientationData(orientation);
 }
 
 void TestRunner::SetMockScreenOrientation(const std::string& orientation_str) {
   blink::WebScreenOrientationType orientation;
 
   if (orientation_str == "portrait-primary") {
     orientation = WebScreenOrientationPortraitPrimary;
@@ skipping 678 matching lines @@
 }
 
 void TestRunner::DidLosePointerLockInternal() {
   bool was_locked = pointer_locked_;
   pointer_locked_ = false;
   if (was_locked)
     web_view_->didLosePointerLock();
 }
 
 }  // namespace test_runner