Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/writeValue-blacklist.html

Issue 1737423002: bluetooth: Add Web Bluetooth blacklist checks to readValue & writeValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-char-
Patch Set: addressed ortuno Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/writeValue-blacklist.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/writeValue-blacklist.html b/third_party/WebKit/LayoutTests/bluetooth/writeValue-blacklist.html
new file mode 100644
index 0000000000000000000000000000000000000000..d11d6be240a46200b9c06712195bfc356d241755
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/bluetooth/writeValue-blacklist.html
@@ -0,0 +1,32 @@
+<!DOCTYPE html>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="resources/bluetooth-helpers.js"></script>
+<script>
+'use strict';
+
+test(t => { assert_true(window.testRunner instanceof Object); t.done(); },
+ 'window.testRunner is required for the following tests.');
+
+promise_test(() => {
+ testRunner.setBluetoothMockDataSet('BlacklistTestAdapter');
+ return requestDeviceWithKeyDown(
+ {
+ filters: [{services: [blacklist_test_service_uuid]}],
+ optionalServices: ['generic_access']
+ })
+ .then(device => device.gatt.connect())
+ .then(gattServer => gattServer.getPrimaryService('generic_access'))
+ .then(service => service.getCharacteristic('gap.peripheral_privacy_flag'))
+ .then(characteristic => {
+ return characteristic.readValue()
+ .then(() => assert_promise_rejects_with_message(
+ characteristic.writeValue(new Uint8Array(1 /* length */)),
+ new DOMException(
+ 'writeValue() called on blacklisted object marked exclude-writes.' +
+ ' https://goo.gl/4NeimX',
+ 'SecurityError'),
+ 'writeValue() should reject.'))
+ });
+}, 'Characteristic with exclude-writes fullfills read and rejects write.');
+</script>

Powered by Google App Engine
This is Rietveld 408576698