Modified the behavior of "Hide Toolbar in Full Screen"

chrome/common/pref_names.cc

Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index eea95a4d05aa752994ca2b587062a6400bcbdbc3..519ef96c15409e5221f041b0e5a3fc10df80ac6e 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -385,9 +385,9 @@ const char kContextualSearchEnabled[] = "search.contextual_search_enabled";
 // window when the user is attempting to quit. Mac only.
 const char kConfirmToQuitEnabled[] = "browser.confirm_to_quit";
 
-// Boolean that indicates whether the browser should hide the toolbar when it's
+// Boolean that indicates whether the browser should show the toolbar when it's
 // in fullscreen. Mac only.
-const char kHideFullscreenToolbar[] = "browser.hide_fullscreen_toolbar";

[Robert Sesek, 2016/02/26 20:42:27]

Did this pref make it to stable? Should the value be migrated?

[spqchan, 2016/02/26 23:24:59]

Not yet, but given the amount of time we have left, it may as well be.
That's a good point, how do we migrate these values?
It might be safe to not migrate this value since it's pretty minor.

Alternatively, I can change it back to the hide_fullscreen_toolbar. I'm
concerned that it will be confusing in the codebase though.

[Robert Sesek, 2016/02/29 18:05:34]

Will it make it to stable? If not, then I don't think the migration is worth it.
If this pref will make it to stable, we should migrate it IMO.

The way to do that is to keep register the new pref, migrate the value from the
old pref, clear the old pref (to prevent migration more than once), and then in
a follow-up milestone, delete the old pref.
Agreed.

+const char kShowFullscreenToolbar[] = "browser.show_fullscreen_toolbar";
 #endif
 
 // Boolean which specifies whether we should ask the user if we should download